TeamForge : Post

Forum Topic - Voting:

View: as

Mario Charest

03/19/2008 1:02 PM

post5967

I'm curious.  Are the voting rules in the OSRev forums build on top of svn.  Is it enforced somehow through some of the 
available svn hooks?

It snowed again this morning in Montreal, sigh!

- Mario

Attilla Danko(deleted)

03/19/2008 1:12 PM

post5969

Re: Voting

Voting???

Do you mean people postint "+1" in response to requests for code reviews?

If so, the answer is:

No. It's just a convention. Our internal SVN checks that our log messages
lists the names of at least one code reviewer. But it's not tied into the
form. And it never stops a commit.

Mario Charest wrote:
> I'm curious.  Are the voting rules in the OSRev forums build on top of 
> svn.  Is it enforced somehow through some of the available svn hooks?
> 
> It snowed again this morning in Montreal, sigh!
> 
> - Mario
> 
> 
> 
> _______________________________________________
> OSMeta
> http://community.qnx.com/sf/go/post5967
>

Colin Burgess(deleted)

03/19/2008 1:16 PM

post5971

Re: Voting


Attilla Danko wrote:
> Voting???
> 
> Do you mean people postint "+1" in response to requests for code reviews?
> 
> If so, the answer is:
> 
> No. It's just a convention. Our internal SVN checks that our log messages
> lists the names of at least one code reviewer. But it's not tied into the
> form. And it never stops a commit.

It will stop a commit if a PR is not noted.  Without a CI it will merely send
an email to management.

> Mario Charest wrote:
>  > I'm curious.  Are the voting rules in the OSRev forums build on top of
>  > svn.  Is it enforced somehow through some of the available svn hooks?
>  >
>  > It snowed again this morning in Montreal, sigh!
>  >
>  > - Mario
>  >
>  >
>  >
>  > _______________________________________________
>  > OSMeta
>  > http://community.qnx.com/sf/go/post5967
>  >
> 
> 
> _______________________________________________
> OSMeta
> http://community.qnx.com/sf/go/post5969
> 

-- 
cburgess@qnx.com

Mario Charest

03/19/2008 3:23 PM

post5975

Re: Voting

> 
> 
> Attilla Danko wrote:
> > Voting???
> > 
> > Do you mean people postint "+1" in response to requests for code reviews?
> > 
> > If so, the answer is:
> > 
> > No. It's just a convention. Our internal SVN checks that our log messages
> > lists the names of at least one code reviewer. But it's not tied into the
> > form. And it never stops a commit.
> 
> It will stop a commit if a PR is not noted.  Without a CI it will merely send
> an email to management.
> 

Care to make your svn hook files public?

Attilla Danko

03/19/2008 5:30 PM

post5983

Re: Voting

Do you mean "publish the svn logs"? 

If so they should already be published on the external svn. For example this commit lists the pr number, the code 
reviewers and a short description of the reason for the change
<http://community.qnx.com/integration/viewcvs/viewcvs.cgi?root=coreos_pub&rev=158307&system=exsy1001&view=rev>;

However, i think there is a problem with some stuff being exposed from the inernal svn reposistory to the external one, 
since some of the log entries have been replaced with string "coreos" which is not too helpful.

-ad

Mario Charest

03/20/2008 1:53 AM

post5987

Re: Voting

> Do you mean "publish the svn logs"? 
> 

No I mean the scripts that lives in the svn repository, under hook.  These are the scripts/programs that are run by the 
svnserver during various phase of operation, like before and after a commit.


> If so they should already be published on the external svn. For example this 
> commit lists the pr number, the code reviewers and a short description of the 
> reason for the change
> <http://community.qnx.com/integration/viewcvs/viewcvs.cgi?root=coreos_pub&rev=158307&system=exsy1001&view=rev>;
> 
> However, i think there is a problem with some stuff being exposed from the 
> inernal svn reposistory to the external one, since some of the log entries 
> have been replaced with string "coreos" which is not too helpful.
> 
> -ad

Return